Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always-on AV1 in --release; opt-in to nasm-optimizations #7661

Merged
merged 5 commits into from
Oct 9, 2024
Merged

Always-on AV1 in --release; opt-in to nasm-optimizations #7661

merged 5 commits into from
Oct 9, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Oct 9, 2024 •
edited by github-actions bot
Loading

What

Even without nasm, it is pretty fast.

I also added a warning to the user that they can get more performance by enabling the nasm feature.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added exclude from changelog PRs with this won't show up in CHANGELOG.md 🎞️ video labels Oct 9, 2024
@emilk emilk added this to the 0.19 - Dataframe and web video milestone Oct 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024

Deployed docs

Commit Link
3533997 https://landing-nadqul8es-rerun.vercel.app/docs

@emilk emilk marked this pull request as ready for review October 9, 2024 14:53
@nikolausWest
Copy link
Member

Can a python & pip user get the nasm optimization without compiling form source? If not, it probably shouldn't be a prominent warning

@emilk
Copy link
Member Author

emilk commented Oct 9, 2024 •
edited
Loading

The nasm feature is on by default for our pip package build, so they won't see a warning.

The warning is for users that do cargo install rerun-cli

@Wumpf Wumpf self-requested a review October 9, 2024 16:20
Wumpf
Wumpf approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

title a bit misleading. It's still off on debug

@Wumpf
Copy link
Member

Wumpf commented Oct 9, 2024

how are we building the standalone executables that we upload to GH? Those should also get that feature flag

@emilk emilk mentioned this pull request Oct 9, 2024
Closed
@emilk
Copy link
Member Author

emilk commented Oct 9, 2024

how are we building the standalone executables that we upload to GH? Those should also get that feature flag

Good question. I'v created a separate issue for it:

@emilk emilk changed the title Always-on AV1; opt-in to nasm-optimizations Always-on AV1 in --release; opt-in to nasm-optimizations Oct 9, 2024
@emilk emilk merged commit 14590be into main Oct 9, 2024
43 of 44 checks passed
@emilk emilk deleted the emilk/default-on-av1 branch October 9, 2024 19:04
@jleibs jleibs mentioned this pull request Oct 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🎞️ video
Projects
None yet
Milestone
0.19 - Dataframe and video
Development

Successfully merging this pull request may close these issues.
3 participants
@emilk @nikolausWest @Wumpf